Skip to content

Add condition for action target resolved#278

Merged
google-prow-robot merged 3 commits intoknative:masterfrom
vaikas:issue-217
Jul 25, 2018
Merged

Add condition for action target resolved#278
google-prow-robot merged 3 commits intoknative:masterfrom
vaikas:issue-217

Conversation

@vaikas
Copy link
Copy Markdown
Contributor

@vaikas vaikas commented Jul 25, 2018

Fixes #217

Proposed Changes

  • Introduce a condition for ActionTarget resolved

@google-prow-robot google-prow-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 25, 2018
@google-prow-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vaikas-google

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-prow-robot google-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 25, 2018
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jul 25, 2018

/assign @evankanderson


const (
actionTargetResolveFailMessage = "action target fail resolved"
actionTargetResolveSuccessMessage = "action target fail resolved"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

actionTargetResolveSuccessMessage = "action target fail resolved"

actionTargetResolveFailReason = "ActionTargetResolveFailed"
actionTargetResolveSuccessReason = "ActionTargetResolveFailed"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@google-prow-robot google-prow-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 25, 2018
@google-prow-robot google-prow-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 25, 2018
Copy link
Copy Markdown
Member

@mattmoor mattmoor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-prow-robot google-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2018
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jul 25, 2018

/retest

1 similar comment
@vaikas
Copy link
Copy Markdown
Contributor Author

vaikas commented Jul 25, 2018

/retest

@google-prow-robot google-prow-robot merged commit 540e451 into knative:master Jul 25, 2018
@vaikas vaikas deleted the issue-217 branch July 30, 2018 04:17
matzew pushed a commit to matzew/eventing that referenced this pull request Oct 9, 2019
pierDipi added a commit to pierDipi/eventing that referenced this pull request Jul 21, 2023
…native#278)

* Refactor PingSource adapter client creation (knative#6880)

This is just a refactoring to make it easier to implement Eventing TLS

Part of knative#6879

---------



* Send namespace header in MT components (knative#7048)

When running MT components [1] in mesh mode with Istio,
we lose the ability to define fine grained policies since we
don't know the resource namespace that originated such
request, therefore, by having a `Kn-Namespace` header,
in mesh mode, users case define fine-grained policies and
isolate namespaces.

[1] IMC, MTChannelBasedBroker, and PingSource



* Fix compile error



---------

Signed-off-by: Pierangelo Di Pilato <pierdipi@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

As a user, I want status updates for fatal config errors

4 participants